fix: relax transformers dependency #309
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @AzulGarza: given this only touches the minimum transformer version, I don’t have concerns. @abdulfatir do you have any concern? |
|
Thanks @AzulGarza! @lostella I believe we bumped |
|
@AzulGarza see the above answer; I think merging this change is not ideal since that will raise again security alerts. Could you maybe consider taking |
|
thanks, @lostella and @abdulfatir! i didn't know about no-deps, appreciate the hint! i think it fixes the issue:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
this pr relaxes the version constraint for the
transformersdependency. i’ve tested the minimal proposed version, and all tests pass successfully.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.